On Wed, Dec 07, 2016 at 03:00:29PM +0000, Atul Raj wrote:
> On 7 Dec 2016 18:56, "Greg KH" <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Wed, Dec 07, 2016 at 05:46:09PM +0530, Atul Raj wrote:
> > > Instead of using:
> > > if (cond) {
> > > WARN_ON(1);
> > > do_stuff();
> > > }
> > >
> > > Use a better pattern with WARN_ON() placed in if condition:
> > >
> > > if (WARN_ON(cond))
> > > do_stuff();
> >
> > Why? What does this help with?
> >
>
> This removed a extra line from code so I suggested the patch.
> I tried to submit the basic patch taking inspiration from below commit
> Please check commit 2bdf6ea5
> Please let me know how does this helped with?
>
> > And why are you sending patches that are different, yet have identical
> > subject lines?
>
> I made two different patched but did not notice the subject is same.
> Sorry for that. If you think the patches are worth I will send you the
> patches again.
>
> >
> > thanks,
> >
> > greg k-h
>
> I am in learning phase and I will persistently try until I succeed. :)
I suggest you learn on the drivers/staging/ portion of the kernel, which
is where that work is welcomed, before trying to touch other areas of
the kernel that are not as easy to contribute to unless you know what
you are doing.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
