Hi, Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> writes: > hi Mathias, > > here's a much longer series of cleanups which I have been working on for > the past few days. Let me know what you think about it. > > I did some light tests SKL and everything still works as before. I know > you have some reservations about my changes to trb_in_td() but IMHO, if > we can assume this function to be always correct, there's no need to add > debugging messages to it and as for the trb_in_td() call which existed > only for debugging purposes, I guess we need to find a better way of > adding debug statements for that part of the code. > > Let me know what you think. I have patches updated in xhci-cleanup on my k.org branch. Just making sure these are all the comments I'll get. Mathias, are you done reviewing? (no, I'm not walking 2.5m to ask you in person heh) -- balbi
Attachment:
signature.asc
Description: PGP signature