Re: [PATCH 2/3 v3] xhci: Fix race related to abort operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 29 Nov 2016 02:11:48 +0900, OGAWA Hirofumi
<hirofumi@xxxxxxxxxxxxxxxxxx> wrote:
> Your ts651_4.9-rc7 (latest commit) is broken somehow. The following
> incremental patch for ts651_4.9-rc7 is to fix it. With this, xhci will
> become same with mine.

Thanks, applied.

As a test, I tried to get the xhci driver to give up on initialise the
controller (the bug I reported originally on 4.1.4)
I failed to reproduce this bug, despite having applied the following
revert:
  commit 4cfad5b7601a46b8f3c5b267abe52a9cbf77bdaf
  Author: Vincent Pelletier <plr.vincent@xxxxxxxxx>
  Date:   Sun Nov 27 01:23:46 2016 +0000
      Revert "xhci: give command abortion one more chance before killing xhci"
      This reverts commit a6809ffd1687b3a8c192960e69add559b9d32649.

I gave up after about 10 boots, with a mix of cold boots and warm
reboots.

Problem is, I could not reproduce the "Command completion event does not
match command" error either (which used to happen even on successful
boots), even without your patch. Checking my syslog, I see it did
happen with my previous kernel (vanilla 4.6.0).
Could something else since 4.6.0 have improved xhci initialisation on
  00:14.0 USB controller: Intel Corporation Atom Processor Z36xxx/Z37xxx, Celeron N2000 Series USB xHCI (rev 0e)
>From a naive "git log drivers/usb/host/xhci*" read,
  commit 3425aa03f484d45dc21e0e791c2f6c74ea656421
  Author: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
  Date:   Wed Jun 1 18:09:08 2016 +0300
      xhci: Fix handling timeouted commands on hosts in weird states.
caught my eye, along with some quirk reworks but I can't tell if they
could be related to the improvement.
FWIW the following log line
did not change since (at least) 4.4.0 on this machine:
  xhci_hcd 0000:00:14.0: hcc params 0x200077c1 hci version 0x100 quirks 0x00009810

So I cannot tell for sure whether your patch set improves the situation.

What I can say though is that after about 5 boots *with* your patch is
that I had no boot failure nor xhci warnings, so at least no obvious
regression either.

Regards,
-- 
Vincent Pelletier
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux