On Fri, Dec 02, 2016 at 10:04:39AM -0800, Guenter Roeck wrote: > The driver interface is not my area of expertise. As such, my testing > and understanding of that part was limited to "it appears to work, > it must be ok". I very much relied on you to get this part right. > > That makes me feel really bad. It isn't fun to have my "Reviewed-by" > on a patch that gets (and apparently deserves) a WTF from a senior > kernel maintainer. This hurts both your and my reputation, and obviously > will make me quite hesitant to add a "Reviewed-by:" to the next version > of the series. Hey, it doesn't bother me at all, I want and need your reviews of those portions that I don't know as well (i.e. the userspace api and functionality.) So don't take it personally, the driver model isn't that easy of a topic to mess with in places, loads of people get it wrong. > No more shortcuts, please. I totally agree :) Also, I want some Intel reviews on this, that should help make a lot of these types of issues go away... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
