On 12/02/2016 04:37 PM, Shuah Khan wrote: > On 12/02/2016 08:27 AM, Krzysztof Opasiak wrote: >> >> >> On 12/02/2016 04:15 PM, Shuah Khan wrote: >>> Hi Krzysztof, >>> >>> Thanks for the patch. >>> >>> On 12/01/2016 10:02 AM, Krzysztof Opasiak wrote: >>>> Current implementation of init_vudc_hw() adds ep0 to ep_list >>>> and then after looping through all endpoints removes it from >>>> that list. >>>> >>>> As this may be misleading let's refactor this function >>>> and avoid adding and removing ep0 to eplist and place it >>>> immediately in correct place. >>> >>>> >>>> Signed-off-by: Krzysztof Opasiak <k.opasiak@xxxxxxxxxxx> >>>> --- >>>> drivers/usb/usbip/vudc_dev.c | 38 +++++++++++++++++++++----------------- >>>> 1 file changed, 21 insertions(+), 17 deletions(-) >>>> >>>> diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c >>>> index 7091848..a5ca29b 100644 >>>> --- a/drivers/usb/usbip/vudc_dev.c >>>> +++ b/drivers/usb/usbip/vudc_dev.c >>>> @@ -549,30 +549,37 @@ static int init_vudc_hw(struct vudc *udc) >>>> sprintf(ep->name, "ep%d%s", num, >>>> i ? (is_out ? "out" : "in") : ""); >>>> ep->ep.name = ep->name; >>>> + >>>> + ep->ep.ops = &vep_ops; >>>> + >>>> + ep->halted = ep->wedged = ep->already_seen = >>>> + ep->setup_stage = 0; >>> >>> Do you need to clear these explicitly. kcalloc() should do it for you. >> >> Well, that's true. I may remove this if you like. > > Please do. It is redundant. > I will do this and send v2 shortly. Thanks, -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
