Re: [PATCH v13 03/10] usbip: exporting devices: new connect operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 12/02/2016 08:05 AM, fx IWATA NOBUO wrote:
> Hello,
> 
>> In my humble opinion connect is not a best name for this operation.
> 
> Yes. I think connect is not perfect.
> 
>> it not only starts the connection to a remote server but also> exports
>> a device. I think that a name like export or attach_to_remote would be
>> more suitable. (...)
> 
> I think one word name is better.
> 
> Considering that attach is corresponding to import request, I think
> export is not good. Furthermore, export is already used in many places
> of the code, ex. usbip_host_common.c: usbip_export_device(). So I don't
> want to use export.
> 
> Operation | PDU     | Description
> ----------+---------+-----------------
> attach    |import   |invite a device
> detach    |NA       |quit invited
> (     )   |export   |dedicate a device
> (     )   |un-export|quit dedicated
> 
> I think connect/disconnect is not bad.
> I will change it if there's user friendly, well-known and suit with
> existing name.
> 

Ehh, as usually the non technical problems are the toughest one;)

I would be happy to suggest you a good name for this but I also cannot
figure out any;)

connect was not perfect from my point of view as it suggest that we are
only establishing a tcp connection not connecting particular device but
maybe it's only mine problem and misunderstanding;)

Best regards,
-- 
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux