On Thu, 1 Dec 2016 csmanjuvijay@xxxxxxxxx wrote:
> From: Manjunath Goudar <csmanjuvijay@xxxxxxxxx>
>
> The ohci_hcd_pxa27x_drv_probe function is not doing anything other
> than calling usb_hcd_pxa27x_probe function so ohci_hcd_pxa27x_drv_probe
> function is useless that is why removed ohci_hcd_pxa27x_drv_probe
> function and renamed usb_hcd_pxa27x_probe function to
> ohci_hcd_pxa27x_drv_probe for proper naming.
>
> The ohci_hcd_pxa27x_remove function is also not doing anything other than
> calling usb_hcd_pxa27x_remove that is why removed ohci_hcd_pxa27x_remove
> function and renamed usb_hcd_pxa27x_remove to ohci_hcd_pxa27x_remove for
> proper naming.
>
> Signed-off-by: Manjunath Goudar <csmanjuvijay@xxxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
> Changelog v1 -> v2:
> Removed warnings and errors of checkpatch.pl script.
> Replaced unuseful with useless in patch commit message for proper meaning.
> Removed usb_disabled() from ohci_hcd_pxa27x_drv_probe function because it
> is already existing in ohci_pxa27x_init function
>
> Changelog v2 -> v3:
> Removed checkpatch.pl warnings and errors cleanup code which is not related
> to this patch.
> drivers/usb/host/ohci-pxa27x.c | 38 ++++++++++++--------------------------
> 1 file changed, 12 insertions(+), 26 deletions(-)
Just one little thing...
> diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c
> index a667cf2..1b6b46e 100644
> --- a/drivers/usb/host/ohci-pxa27x.c
> +++ b/drivers/usb/host/ohci-pxa27x.c
> @@ -404,7 +404,7 @@ static int ohci_pxa_of_init(struct platform_device *pdev)
>
>
> /**
> - * usb_hcd_pxa27x_probe - initialize pxa27x-based HCDs
> + * ohci_hcd_pxa27x_probe - initialize pxa27x-based HCDs
> * Context: !in_interrupt()
> *
> * Allocates basic resources for this USB host controller, and
> @@ -412,7 +412,7 @@ static int ohci_pxa_of_init(struct platform_device *pdev)
> * through the hotplug entry's driver_data.
> *
> */
> -int usb_hcd_pxa27x_probe (const struct hc_driver *driver, struct platform_device *pdev)
> +static int ohci_hcd_pxa27x_probe(struct platform_device *pdev)
> {
> int retval, irq;
> struct usb_hcd *hcd;
> @@ -423,6 +423,8 @@ int usb_hcd_pxa27x_probe (const struct hc_driver *driver, struct platform_device
> struct clk *usb_clk;
> unsigned int i;
>
> + pr_debug("In ohci_hcd_pxa27x_drv_probe");
> +
Don't insert this pr_debug line. After fixing that up, you can add:
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
