On Wed, Nov 30, 2016 at 11:59:49PM +0000, csmanjuvijay@xxxxxxxxx wrote: > From: Manjunath Goudar <csmanjuvijay@xxxxxxxxx> > > The ohci_hcd_pxa27x_drv_probe function is not doing anything other > than calling usb_hcd_pxa27x_probe function so ohci_hcd_pxa27x_drv_probe > function is useless that is why removed ohci_hcd_pxa27x_drv_probe > function and renamed usb_hcd_pxa27x_probe function to > ohci_hcd_pxa27x_drv_probe for proper naming. > > The ohci_hcd_pxa27x_remove function is also not doing anything other than > calling usb_hcd_pxa27x_remove that is why removed ohci_hcd_pxa27x_remove > function and renamed usb_hcd_pxa27x_remove to ohci_hcd_pxa27x_remove for > proper naming. > > Signed-off-by: Manjunath Goudar <csmanjuvijay@xxxxxxxxx> > Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: linux-usb@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > > Changelog v1 -> v2: > 1.Removed warnings and errors of checkpatch.pl script. > 2.Replaced unuseful with useless in patch commit message for proper meaning. > 3.Removed usb_disabled() from ohci_hcd_pxa27x_drv_probe function because it > is already existing in ohci_pxa27x_init function > --- > drivers/usb/host/ohci-pxa27x.c | 42 ++++++++++++++---------------------------- > 1 file changed, 14 insertions(+), 28 deletions(-) changelog should go below --- line. > > diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c > index a667cf2..171f28f2 100644 > --- a/drivers/usb/host/ohci-pxa27x.c > +++ b/drivers/usb/host/ohci-pxa27x.c > @@ -157,9 +157,9 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode) > uhcrhdb |= (0x7<<17); > break; > default: > - printk( KERN_ERR > + printk(KERN_ERR No, don't do checkpatch cleanups in portions of the code you are not actually changing for your "real" patch. That's a mess. You can send checkpatch patches as follow-on patches, but not with this one. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
