Re: [PATCH v2 2/3] Revert "usb: dwc2: gadget: fix TX FIFO size and address initialization"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/24/2016 1:15 PM, Stefan Wahren wrote:
> Hi John,
> 
>> John Youn <johnyoun@xxxxxxxxxxxx> hat am 18. Oktober 2016 um 02:36
>> geschrieben:
>>
>>
>> This reverts commit aa381a7259c3 ("usb: dwc2: gadget: fix TX FIFO size
>> and address initialization").
>>
>> The original commit removed the FIFO size programming per endpoint. The
>> DPTXFSIZn register is also used for DIEPTXFn and the SIZE field is r/w
>> in dedicated fifo mode. So it isn't appropriate to simply remove this
>> initialization as it might break existing behavior.
>>
>> Also, some cores might not have enough fifo space to handle the
>> programming method used in the reverted patch, resulting in fifo
>> initialization failure.
> 
> since the original patch is still necessary for bcm2835 gadget support i want to
> know if there is an alternative solution?
> 
> Stefan
> 

Hi Stefan,

We are working on a solution to have the driver initialize the FIFOs
more intelligently as the default behavior so it should never fail.

Regards,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux