Re: [PATCH] add DWR-158 in usb option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2016-11-16 15:53, Oliver Neukum wrote:
On Wed, 2016-11-16 at 10:22 +0700, Lars Melin wrote:
On 2016-11-16 03:20, Giuseppe Lippolis wrote:
Signed-off-by: Giuseppe Lippolis <giu.lippolis@xxxxxxxxx>
---
Adding support for 3G modem DWR-158 from Dlink (I found it embedded in the
DWR-512).
---

--- drivers/usb/serial/option.c.orig	2016-11-15 21:05:16.987504020 +0100
+++ drivers/usb/serial/option.c	2016-11-15 21:08:27.722378924 +0100
@@ -306,6 +306,9 @@ static void option_instat_callback(struc
 #define DLINK_PRODUCT_DWM_652_U5		0xce16
 #define DLINK_PRODUCT_DWM_652_U5A		0xce1e

+#define DLINK_ATL_VENDOR_ID			0x2001
+#define DLINK_PRODUCT_DWM_158			0x7d04
+
 #define QISDA_VENDOR_ID				0x1da5
 #define QISDA_PRODUCT_H21_4512			0x4512
 #define QISDA_PRODUCT_H21_4523			0x4523
@@ -1812,6 +1815,7 @@ static const struct usb_device_id option
 	{ USB_DEVICE(DLINK_VENDOR_ID, DLINK_PRODUCT_DWM_652) },
 	{ USB_DEVICE(ALINK_VENDOR_ID, DLINK_PRODUCT_DWM_652_U5) }, /* Yes,
ALINK_VENDOR_ID */
 	{ USB_DEVICE(ALINK_VENDOR_ID, DLINK_PRODUCT_DWM_652_U5A) },
+	{ USB_DEVICE(DLINK_ATL_VENDOR_ID, DLINK_PRODUCT_DWM_158) },
 	{ USB_DEVICE(QISDA_VENDOR_ID, QISDA_PRODUCT_H21_4512) },
 	{ USB_DEVICE(QISDA_VENDOR_ID, QISDA_PRODUCT_H21_4523) },
 	{ USB_DEVICE(QISDA_VENDOR_ID, QISDA_PRODUCT_H20_4515) },

--
NAK.
The verbose lsusb display which you pasted in your first mail shows
interface #0 and #1 to be used as netdev with cdc_ether as driver.
You must blacklist them in the option driver which otherwise will
claim them.

Hi,

why? This thing is no ethernet. If a more specific driver, that can do
do more, like link quality or AP selection, is available, we want to use
that.
So, if you use a black list, use it in cdc_ether.

	Regards
		Oliver


adding Johan as he is the maintainer


The patch will make the option driver claim the cdc_ether interfaces.
It can be fixed by either blacklisting those interfaces from option or
whitelist only the serial interfaces by including class matching.
Whitelisting is of course better.

rgds
/Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux