On 2016-11-16 02:13, Giuseppe Lippolis wrote:
Dear all,
I'm porting the Dlink DWR-512 device to LEDE (embedded linux).
This device embed a 3G modem connected through the usb bus .
The modem work properly with the option kernel module.
I added these line in the
#define DLINK_PRODUCT_DWM_652 0x3e04
#define DLINK_PRODUCT_DWM_652_U5 0xce16
#define DLINK_PRODUCT_DWM_652_U5A 0xce1e
+ #define DLINK_ATL_VENDOR_ID 0x2001
+ #define DLINK_PRODUCT_DWM_158 0x7d04
#define QISDA_VENDOR_ID 0x1da5
#define QISDA_PRODUCT_H21_4512 0x4512
[...]
{ USB_DEVICE(ALINK_VENDOR_ID, DLINK_PRODUCT_DWM_652_U5) }, /* Yes,
ALINK_VENDOR_ID */
{ USB_DEVICE(ALINK_VENDOR_ID, DLINK_PRODUCT_DWM_652_U5A) },
+ { USB_DEVICE(DLINK_ATL_VENDOR_ID, DLINK_PRODUCT_DWM_158) },
{ USB_DEVICE(QISDA_VENDOR_ID, QISDA_PRODUCT_H21_4512) },
{ USB_DEVICE(QISDA_VENDOR_ID, QISDA_PRODUCT_H21_4523) },
You have invented what looks to me as a bogus name for VID 0x2001 in
order to get it alphabetically sorted among other D-Link devices with a
different VID.
There is already a section where the 0x2001 devices resides and that is
the right place to add this device.
Alphabetical sorting is worthless and so is the #defines for vid's and
pid's. No one should ever search in the option driver by device name,
but should instead do it by vid and pid directly without going via
wrong/fake/invented defines. The whole driver is a big mess..
/Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
