On Mon, Feb 09, 2009 at 03:03:11PM +0100, ext Giuseppe GORGOGLIONE wrote: > > > > > From: Felipe Balbi [mailto:felipe.balbi@xxxxxxxxx] > > Sent: Monday, February 09, 2009 1:22 PM > > To: ext Giuseppe GORGOGLIONE > > Cc: Balbi Felipe (Nokia-D/Helsinki); linux-usb@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH] USB-MUSB: fix crash due to uninitialized pointer > > > > On Mon, Feb 09, 2009 at 11:59:26AM +0100, ext Giuseppe GORGOGLIONE wrote: > > > > > > > > > From: Giuseppe GORGOGLIONE > > > > > > An uninitialized pointer is used to reference MUSB registers when the > > > device is setup to use static FIFOs and to configure endpoints from > > > hardware, causing a kernel crash. This bug was trivial but probably > > > never catched before because modern MUSB devices are designed to have > > > dynamic FIFOs and to configure endpoints from tables. > > > > > > Tested on STMicroelectronics Cartesio STA2062, an ARM based SoC which > > > is integrating two Mentor Inventra devices, one with static FIFOs and > > > static endpoint configuration from HW, and one with dynamic FIFOs and > > > dynamic endpoint configuration from tables. > > > Only the first device was hitting the bug. > > > Reference kernel version 2.6.28.4 > > > > > > Signed-off-by: Giuseppe GORGOGLIONE <giuseppe.gorgoglione@xxxxxx> > > > > This part is can see that won't apply on top of current musb's patches, > Blackfin's patches moved this to a > > static inline musb_read_fifosize(). > > > > Update your kernel tree and send this patch again, please ;-) > > I'll be glad, as soon as I get reference to the latest MUSB tree. :-) it's in current mainline tree. linux-2.6.git from linus. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
