Re: [PATCH v2 11/30] usb: dwc2: gadget: Add DDMA chain fill and parse functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

John Youn <johnyoun@xxxxxxxxxxxx> writes:
> From: Vahram Aharonyan <vahrama@xxxxxxxxxxxx>
>
> Add dwc2_gadget_get_desc_params() function to define descriptor entry
> parameters based on the endpoint type.
>
> Add dwc2_gadget_config_nonisoc_xfer_ddma() function, which programs DDMA
> chain entries with corresponding values based on the received DMA buffer
> and transfer length in case of non-isochronous endpoint. Isochronous
> endpoints' DMA descriptors will be filled separately.
>
> Add dwc2_gadget_get_xfersize_ddma() function to iterate over DDMA chain
> and get info on bytes remaining in descriptor status field after
> transfer complete.
>
> Signed-off-by: Vahram Aharonyan <vahrama@xxxxxxxxxxxx>
> Signed-off-by: John Youn <johnyoun@xxxxxxxxxxxx>

This patch adds build warnings:

  CC [M]  drivers/usb/dwc2/gadget.o
drivers/usb/dwc2/gadget.c:1825:21: warning: ‘dwc2_gadget_get_xfersize_ddma’ defined but not used [-Wunused-function]
 static unsigned int dwc2_gadget_get_xfersize_ddma(struct dwc2_hsotg_ep *hs_ep)
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/dwc2/gadget.c:682:13: warning: ‘dwc2_gadget_config_nonisoc_xfer_ddma’ defined but not used [-Wunused-function]
 static void dwc2_gadget_config_nonisoc_xfer_ddma(struct dwc2_hsotg_ep *hs_ep,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  LD [M]  drivers/usb/dwc2/dwc2.o

I have applied up to the patch right before this one. Please fix the
warning and rebase on testing/next

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux