On Sun, Nov 6, 2016 at 7:56 PM, Chen-Yu Tsai <wens@xxxxxxxx> wrote: > On Mon, Nov 7, 2016 at 9:29 AM, Peter Chen <hzpeterchen@xxxxxxxxx> wrote: >> On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote: >>> Quoting Peter Chen (2016-10-24 18:16:32) >>> > On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote: >>> > > Quoting Chen-Yu Tsai (2016-10-24 05:19:05) >>> > > > Hi, >>> > > > >>> > > > On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd <stephen.boyd@xxxxxxxxxx> wrote: >>> > > > > The ULPI bus can be built as a module, and it will soon be >>> > > > > calling these functions when it supports probing devices from DT. >>> > > > > Export them so they can be used by the ULPI module. >>> > > > > >>> > > > > Acked-by: Rob Herring <robh@xxxxxxxxxx> >>> > > > > Cc: <devicetree@xxxxxxxxxxxxxxx> >>> > > > > Signed-off-by: Stephen Boyd <stephen.boyd@xxxxxxxxxx> >>> > > > > --- >>> > > > > drivers/of/device.c | 2 ++ >>> > > > > 1 file changed, 2 insertions(+) >>> > > > > >>> > > > > diff --git a/drivers/of/device.c b/drivers/of/device.c >>> > > > > index 8a22a253a830..6719ab35b62e 100644 >>> > > > > --- a/drivers/of/device.c >>> > > > > +++ b/drivers/of/device.c >>> > > > > @@ -225,6 +225,7 @@ ssize_t of_device_get_modalias(struct device *dev, char *str, ssize_t len) >>> > > > > >>> > > > > return tsize; >>> > > > > } >>> > > > > +EXPORT_SYMBOL_GPL(of_device_get_modalias); >>> > > > > >>> > > > > int of_device_request_module(struct device *dev) >>> > > > > { >>> > > > > @@ -290,6 +291,7 @@ void of_device_uevent(struct device *dev, struct kobj_uevent_env *env) >>> > > > > } >>> > > > > mutex_unlock(&of_mutex); >>> > > > > } >>> > > > > +EXPORT_SYMBOL_GPL(of_device_uevent_modalias); >>> > > > >>> > > > This is trailing the wrong function. >>> > > > >>> > > >>> > > Good catch. Must have been some bad rebase. >>> > > >>> > > Peter, can you fix it while applying or should I resend this patch? >>> > > >>> > >>> > But, this is device tree patch. I can only get chipidea part and other >>> > USB patches if Greg agrees. >>> > >>> >>> Were you expecting Rob to take the drivers/of/* patches? Sorry I thought >>> Rob acked them so they could go through usb with the other changes. >> >> I am just worried about possible merge error when linus pulls both OF >> and USB tree. Greg, is it ok the OF patches through USB tree with OF >> maintainer's ack? > > May I suggest putting the OF patches on an immutable branch so other > subsystems can pull them in without pulling in the USB patches? At > least I want to use them in the I2C subsystem, and in the sunxi-rsb > driver. Do you have patches using this already. If not, it is starting to get a bit late for v4.10. I can apply this, but then you'll just be pulling in other DT patches. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html