On Thu, Oct 13, 2016 at 12:52:08PM +0900, Nobuo Iwata wrote:
> New disconnect operation.
We need a lot more text here than just this, as it does not explain why
this patch is needed at all :(
>
> Signed-off-by: Nobuo Iwata <nobuo.iwata@xxxxxxxxxxxxxxx>
> ---
> tools/usb/usbip/src/Makefile.am | 2 +-
> tools/usb/usbip/src/usbip.c | 6 +
> tools/usb/usbip/src/usbip.h | 2 +
> tools/usb/usbip/src/usbip_disconnect.c | 215 +++++++++++++++++++++++++
> 4 files changed, 224 insertions(+), 1 deletion(-)
>
> diff --git a/tools/usb/usbip/src/Makefile.am b/tools/usb/usbip/src/Makefile.am
> index 0947476..42760c3 100644
> --- a/tools/usb/usbip/src/Makefile.am
> +++ b/tools/usb/usbip/src/Makefile.am
> @@ -7,6 +7,6 @@ sbin_PROGRAMS := usbip usbipd
> usbip_SOURCES := usbip.h utils.h usbip.c utils.c usbip_network.c \
> usbip_attach.c usbip_detach.c usbip_list.c \
> usbip_bind.c usbip_unbind.c usbip_port.c \
> - usbip_connect.c
> + usbip_connect.c usbip_disconnect.c
>
> usbipd_SOURCES := usbip_network.h usbipd.c usbip_network.c
> diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
> index 584d7d5..f0e9e06 100644
> --- a/tools/usb/usbip/src/usbip.c
> +++ b/tools/usb/usbip/src/usbip.c
> @@ -83,6 +83,12 @@ static const struct command cmds[] = {
> .usage = usbip_connect_usage
> },
> {
> + .name = "disconnect",
> + .fn = usbip_disconnect,
> + .help = "Disconnect a USB device from a remote computer",
> + .usage = usbip_disconnect_usage
> + },
> + {
> .name = "list",
> .fn = usbip_list,
> .help = "List exportable or local USB devices",
> diff --git a/tools/usb/usbip/src/usbip.h b/tools/usb/usbip/src/usbip.h
> index f365353..a8cbd16 100644
> --- a/tools/usb/usbip/src/usbip.h
> +++ b/tools/usb/usbip/src/usbip.h
> @@ -32,6 +32,7 @@ int usbip_bind(int argc, char *argv[]);
> int usbip_unbind(int argc, char *argv[]);
> int usbip_port_show(int argc, char *argv[]);
> int usbip_connect(int argc, char *argv[]);
> +int usbip_disconnect(int argc, char *argv[]);
>
> void usbip_attach_usage(void);
> void usbip_detach_usage(void);
> @@ -39,6 +40,7 @@ void usbip_list_usage(void);
> void usbip_bind_usage(void);
> void usbip_unbind_usage(void);
> void usbip_connect_usage(void);
> +void usbip_disconnect_usage(void);
>
> int usbip_bind_device(char *busid);
> int usbip_unbind_device(char *busid);
> diff --git a/tools/usb/usbip/src/usbip_disconnect.c b/tools/usb/usbip/src/usbip_disconnect.c
> new file mode 100644
> index 0000000..8155384
> --- /dev/null
> +++ b/tools/usb/usbip/src/usbip_disconnect.c
> @@ -0,0 +1,215 @@
> +/*
> + * Copyright (C) 2015 Nobuo Iwata
> + * 2011 matt mooney <mfm@xxxxxxxxxxxxx>
> + * 2005-2007 Takahiro Hirofuchi
How can others have copyright on a brand new file? Is it based on their
work? If so, please write that.
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 2 of the License, or
> + * (at your option) any later version.
Are you sure you mean "any later version"?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
