Re: [PATCH 05/30] usb: dwc2: gadget: Enable BNA interrupt in descriptor DMA mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/8/2016 1:16 AM, Felipe Balbi wrote:
> 
> Hi,
> 
> John Youn <johnyoun@xxxxxxxxxxxx> writes:
>> From: Vahram Aharonyan <vahrama@xxxxxxxxxxxx>
>>
>> Update endpoint related register descriptions to add DOEPMSK_BNAMSK.
>>
>> Add BNA interrupt's unmasking during gadget initalization if descriptor
> 
> what does BNA stand for?

Buffer not available. I'll clarify in commit message.

> 
>> DMA mode is selected.
>>
>> Signed-off-by: Vahram Aharonyan <vahrama@xxxxxxxxxxxx>
>> Signed-off-by: John Youn <johnyoun@xxxxxxxxxxxx>
>> ---
>>  drivers/usb/dwc2/gadget.c | 7 +++++++
>>  drivers/usb/dwc2/hw.h     | 1 +
>>  2 files changed, 8 insertions(+)
>>
>> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
>> index 4013518..3ab4d60 100644
>> --- a/drivers/usb/dwc2/gadget.c
>> +++ b/drivers/usb/dwc2/gadget.c
>> @@ -2316,6 +2316,9 @@ static void dwc2_hsotg_epint(struct dwc2_hsotg *hsotg, unsigned int idx,
>>  	if (ints & DXEPINT_BACK2BACKSETUP)
>>  		dev_dbg(hsotg->dev, "%s: B2BSetup/INEPNakEff\n", __func__);
>>  
>> +	if (ints & DXEPINT_BNAINTR)
>> +		dev_dbg(hsotg->dev, "%s: BNA interrupt\n", __func__);
> 
> Why are you enabling interrupts *just* to print out a debugging message?
> Is it really worth the CPU time?
> 

It's implemented later. I'll see if I can reorganize these patches a
bit.

John

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux