Re: [PATCH 02/30] usb: dwc2: Update DMA descriptor structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/8/2016 1:14 AM, Felipe Balbi wrote:
> 
> Hi,
> 
> John Youn <johnyoun@xxxxxxxxxxxx> writes:
>> From: Vahram Aharonyan <vahrama@xxxxxxxxxxxx>
>>
>> Rename DMA descriptor structure from dwc2_hcd_dma_desc to dwc2_dma_desc
>> as it is applies to both host and gadget.
>>
>> Also make it __packed.
> 
> why are you making it packed? Does it _have_ to be packed? If it must,
> why wasn't it before?

We want to guarantee that it reflects the exact descriptor structure
in memory, so probably yes. It was overlooked before and worked
because the compiler likely packed it anyways. This is just to make
sure it does.

> 
> Also, it seems to me that adding __packed should be a separate patch.
> 

Ok.

Regards,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux