On Fri, Feb 06, 2009 at 08:23:06PM +0100, Oliver Neukum wrote: > Am Friday 06 February 2009 19:51:30 schrieben Sie: > > On Fri, Feb 06, 2009 at 12:58:39PM +0100, Oliver Neukum wrote: > > > Am Friday 06 February 2009 12:29:06 schrieb Dirk DeSchepper: > > > > From: Dirk De Schepper <ddeschepper@xxxxxxxx> > > > > > > > > Patch for option.c, based on kernel v2.6.28.3 > > > > - New Novatel and Dell mobile broadband modem products added > > > > - Dell pid variables used in stead of numerical PIDs for known products > > > > > > This is not really an advantage. You usually get the nummeric IDs > > > just fine from lsusb. And you could easily see the nummeric order of entries. > > > These symbolic names do not appear in code, just in the macros > > > where their meaning is clear. You introduce a useless level of indirection. > > > > No, it's fine, we can use all of the descriptive information that we can > > Which descriptive information? The symbolic names used are internal > to the kernel. Exactly, and people look at kernel code all the time :) > > get at times. So changing the defines from a generic one, to a specific > > one to match the device type, only helps out in the end. > > The specifity is not affected at all. If you look at the names that were changed, they are now more descriptive than before, always a good thing to have. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
