On 11/8/2016 1:29 AM, Felipe Balbi wrote:
>
> Hi,
>
> John Youn <johnyoun@xxxxxxxxxxxx> writes:
>> From: Vahram Aharonyan <vahrama@xxxxxxxxxxxx>
>>
>> During USB CV tests found timing issues in Slave mode caused by amount
>> of data printed out to the console. Changed WARNON statement by dev_warn
>> in dwc2_hsotg_init_fifo() and dev_info by dev_dbg in
>> dwc2_hsotg_ep_sethalt().
>
> IMHO, this is the wrong fix. You're just working around another issue
> elsewhere.
>
> Which test is failing because of your debug prints? IIRC, USBCV has
> really, really relaxed timeouts. We really need more details about this
> one.
>
You're right, this shouldn't be here. Will remove in next version.
Regards,
John
>> Signed-off-by: Vahram Aharonyan <vahrama@xxxxxxxxxxxx>
>> Signed-off-by: John Youn <johnyoun@xxxxxxxxxxxx>
>> ---
>> drivers/usb/dwc2/gadget.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
>> index 095af16..71f57de 100644
>> --- a/drivers/usb/dwc2/gadget.c
>> +++ b/drivers/usb/dwc2/gadget.c
>> @@ -204,7 +204,10 @@ static void dwc2_hsotg_init_fifo(struct dwc2_hsotg *hsotg)
>> u32 *txfsz = hsotg->params.g_tx_fifo_size;
>>
>> /* Reset fifo map if not correctly cleared during previous session */
>> - WARN_ON(hsotg->fifo_map);
>> + if (hsotg->fifo_map)
>> + dev_warn(hsotg->dev, "%s: fifo_map is %d\n", __func__,
>> + hsotg->fifo_map);
>> +
>> hsotg->fifo_map = 0;
>>
>> /* set RX/NPTX FIFO sizes */
>> @@ -3957,7 +3960,7 @@ static int dwc2_hsotg_ep_sethalt(struct usb_ep *ep, int value, bool now)
>> u32 epctl;
>> u32 xfertype;
>>
>> - dev_info(hs->dev, "%s(ep %p %s, %d)\n", __func__, ep, ep->name, value);
>> + dev_dbg(hs->dev, "%s(ep %p %s, %d)\n", __func__, ep, ep->name, value);
>>
>> if (index == 0) {
>> if (value)
>> --
>> 2.10.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
