>From: Arnd Bergmann [mailto:arnd@xxxxxxxx] >On Tuesday, October 25, 2016 4:26:28 PM CEST Sriram Dash wrote: >> Do not use dma_coerce_mask_and_coherent for hcd. >> >> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > >The patch is good, but please follow the usual rules for submitting someone else's >patch: > >- As the first line, have "From: Arnd Bergmann <arnd@xxxxxxxx>". > "git format-patch" adds this automatically if you pass that > address as the "--author" argument to "git commit". > >- Add you "Signed-off-by" line at below mine (or any other lines) > >I would also suggest a more elaborate changelog text, the free-form text should >explain why something is done, rather than repeat the subject: > >| The dma mask is correctly set up by the DT probe function, no need to >| override it any more. > Ok Arnd. I will take care for the next version. > Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html