Hi Mark, On Mon, Oct 24, 2016 at 8:19 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Mon, Oct 24, 2016 at 08:11:40PM +0200, Axel Haslam wrote: >> On Mon, Oct 24, 2016 at 7:53 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > >> > does it make sense to report this as a mode, we don't report other error >> > conditions as modes but instead use REGULATOR_STATUS_ with the >> > get_status() operation? > >> I used mode, because when the regulator toggles the overcurrent >> line, it means that it has entered a current limited mode, at least the >> regulator im looking at. ill change to STATUS > > That's not what regulator modes are - please look at the documentation > for the defines here. They're about the quality of regulation. To be able to use regulator to handle the overcurrent pin, i need to be able to somehow retrieve the over current pin state from the regulator driver. As i was trying your suggestion, i remembered why i thought i should use mode instead of status: Status seems to be for internal regulator driver use, there is no regulator_get_status, function and REGULATOR_STATUS_* are defined in driver.h and not in consumer.h as REGULATOR_MODE_* it seems that status is only used to print sysfs info. Would you be ok if i allow consumers to get the status via a new "regulator_get_status" call? Regards Axel. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
