Good work on this patch, nice that it got merged. I was just thinking that as an add-on, you may want to name the gpio lines so they have meaningful names in userspace when you use this with the chardev (I have reasons to believe these GPIOs will be used from userspace, tell me if that is wrong). We currently support naming lines for devicetree and ACPI (in -next). I was thinking on either reusing the .names field of the struct gpiochip to name the lines for the userspace chardev. With the sideeffect of the names getting reflected also to sysfs if using that. We could otherwise add a special function to name the lines from drivers like this that hang off a pluggable bus. Johan/Martyn what is your idea? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html