On Tue, Oct 25, 2016 at 1:04 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Oct 24, 2016 at 10:46:13AM +0530, Jai Krishna wrote: >> Fixing checkstyle warnings except symbolic permission warnings >> (e.g. for S_IWUSR etc.). The symbolic permission warnings seem >> to be widespread; so not fixing those as Im likely missing >> some context on why these are widespread. >> >> Build worked after my changes. >> >> Signed-off-by: Jai Krishna <rjk1024@xxxxxxxxx> >> --- >> drivers/usb/usbip/stub_dev.c | 3 ++- >> drivers/usb/usbip/stub_tx.c | 2 +- >> drivers/usb/usbip/usbip_event.c | 3 +-- >> drivers/usb/usbip/vhci_hcd.c | 8 +++++--- >> drivers/usb/usbip/vhci_sysfs.c | 3 +-- >> drivers/usb/usbip/vudc_transfer.c | 6 +++--- >> 6 files changed, 13 insertions(+), 12 deletions(-) > > Why is "staging:" in the subject line? This isn't a staging driver at > all... > > Also, only do one "type" of a fix at a time (and no "fix all checkpatch > warnings isn't 1 fix)... > > thanks, > > greg k-h Thanks for the review. This is my very first patch. So apologies; genuine newbie mistake. I'll resubmit after incorporating the comments. Thanks Jai -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
