On Thursday 08 January 2009, Qiuping Chen wrote: > + u16 ep_sts; > +#define BAD_PID_TYPE (1 << 15) > +#define CRC_ERROR (1 << 14) > +#define FIFO_ERROR (1 << 13) > +#define DMA_ERROR (1 << 12) > +#define TRANS_COMPLETE (1 << 11) > +#define PING_NAK_SENT (1 << 10) > +#define DMA_IOC (1 << 9) Just for the record, and not something that IMO should change before this gets in the merge queue: - Good style encourages prefixes before such symbols, maybe in this case EP_STS_*, to help make it more clear when you're masking the wrong register. (Talk about bugs that can be very hard to see!) - Also, now that we have them, I prefer seeing BIT() macros used for single bit fields. BIT(9) is hard to be confused by; (1 << 9) takes a moment to make sure it's the right idiom, and not "leftmost bit of the three bit field 7..9". BIT(9) is smaller too. This is pleasantly clean code, overall. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
