On Mon, Feb 02, 2009 at 09:43:04AM +0800, Dave Young wrote: > On Sun, Feb 1, 2009 at 11:51 PM, Greg KH <greg@xxxxxxxxx> wrote: > > On Sun, Feb 01, 2009 at 06:53:23PM +0800, Dave Young wrote: > >> > >> In case with "nousb" booting, serial drivers will trigger kernel oops. > > > > They will? What is the oops message? > > Yes, they will, at lease I saw usb_serial/aircable/ftdi_sio oops. I > will manage to copy the oops message later. > > > > >> Here add usb_disabled() check in usb_serial_init and usb_serial_register > > > > This is odd, is it something new? Why is usb-serial the only driver > > that needs such a thing? > > No, it is not new thing. usb serial drivers normally call > usb_serial_register first, then usb_register, usb_register will fail > due to "nousb" checking, but usb_serial_register no. But as usb_register will fail, shouldn't they properly back out and no oopses happen? This sounds like a simple fix to the drivers that are failing here, not changing the usb-serial core. And this should only be an issue if you build your drivers into the kernel, right? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
