On Fri, Oct 7, 2016 at 5:31 PM, Martyn Welch <martyn.welch@xxxxxxxxxxxxxxx> wrote: > WRT this driver, I think I need to keep set_single_ended, but change .direction_input > to always return a failure and have .direction_output always return success to > avoid pins being driven in unexpected ways. Does that sould acceptable? I'm pretty sure it's OK, I just want you to consider and think these things over. Your conclusion is as good as mine. I suspect I will just ACK your patch when you have it working. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html