Hi Krzysztof, On 9 October 2016 at 22:04, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > On Sun, Oct 09, 2016 at 02:34:14PM +0000, Anand Moon wrote: >> Move the ehci-exynos system PM callbacks within #ifdef CONFIG_PM_SLEEP >> as to avoid them being build when not used. This also allows us to use the >> SET_SYSTEM_SLEEP_PM_OPS macro which simplifies the code. >> >> Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> >> --- >> drivers/usb/host/ehci-exynos.c | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c >> index 42e5b66..1899900 100644 >> --- a/drivers/usb/host/ehci-exynos.c >> +++ b/drivers/usb/host/ehci-exynos.c >> @@ -251,7 +251,7 @@ static int exynos_ehci_remove(struct platform_device *pdev) >> return 0; >> } >> >> -#ifdef CONFIG_PM >> +#ifdef CONFIG_PM_SLEEP > > Does not look like an equivalent change. How will it behave in a config > with !SUSPEND && !HIBERNATE && PM? > [snip] I just wanted to update suspend and resume callback to use SET_SYSTEM_SLEEP_PM_OPS as they are define under CONFIG_PM_SLEEP so I update above to avoid compilation warning/error. http://lxr.free-electrons.com/source/include/linux/pm.h#L321 -Best Regards Anand Moon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
