Hi Baolin, Baolin Wang <baolin.wang@xxxxxxxxxx> writes: >>> But you do! >>> The mA number from the USB configuration is passed to usb_gadget_vbus_draw. >>> Your patch passes that to usb_charger_set_cur_limit_by_type() >>> which calls __usb_charger_set_cur_limit_by_type() which will set the >>> cur_limit for whichever type uchger->type currently is. >>> >>> So when it is not relevant, your code *does* set some current limit. >> >> Suppose the charger type is DCP(it is not relevant to the mA number >> from the USB configuration ), it will not do the USB enumeration, then >> no USB configuration from host to set current. > > From the talking, there are some issues (thanks for Neil's comments) > need to be fixed as below: > 1. Need to add the method getting charger type from extcon subsystem. > 2. Need to remove the method getting charger type from power supply. > 3. There are still some different views about reporting the maximum > current or minimum current to power driver. > > Now the current v16 patchset can work well on my Spreadtrum platform > and Jun's NXP platform, if you like to apply this patchset then I can > send out new patches to fix above issues. If you don't like that, I > can send out new version patchset to fix above issues. Could you give > me some suggestions what should I do next step? Thanks. Merge window just opened, nothing will happen for about 2 weeks. How about you send a new version after merge window closes and we go from there? Fixing 1 and 2 is needed. 3 we need to consider more carefully. Perhaps report both minimum and maximum somehow? Neil, comments? -- balbi
Attachment:
signature.asc
Description: PGP signature
