On Fri, 2016-09-30 at 13:57 -0700, Guenter Roeck wrote: > Code now looks as follows. > > #define PDO_VAR_MIN_VOLT(mv) ((((mv) / 50) & PDO_VAR_MIN_VOLT_MASK) << \ > PDO_VAR_MIN_VOLT_SHIFT) > #define PDO_VAR_MAX_VOLT(mv) ((((mv) / 50) & PDO_VAR_MAX_VOLT_MASK) << \ > PDO_VAR_MAX_VOLT_SHIFT) > #define PDO_VAR_MAX_CURR(ma) ((((ma) / 10) & PDO_VAR_MAX_CURR_MASK) << \ > PDO_VAR_MAX_CURR_SHIFT) When #defines are continued, I generally find it nicer to have the entire definition on a separate line #define PDO_VAR_MIN_VOLT(mv) \ ((((mv) / 50) & PDO_VAR_MIN_VOLT_MASK) << PDO_VAR_MIN_VOLT_SHIFT) > Though maybe I should just ignore line length limits or use shorter defines. When it makes sense, yes please. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
