Am Saturday 31 January 2009 16:35:17 schrieb Alexey Klimov:
> Hello, Oliver
>
> Sorry for asking this question.
No problem. Questions should be asked.
> > } else
> > - dbg("%s: error %d", __func__, status);
> > + err("%s: error %d", __func__, status);
>
> Do your patch use err macros defined in usb.h ?
Yes.
> If yes, probably it's better to avoid using it, because this interface
> may become deprecated. Anyway, Greg should know sitation better.
> If no, sorry for bothering.
They may become obsolete. Then somebody needs to go through
the driver to replace them. Until then, I prefer to keep the driver
uniform in that regard. The patch does what it says it does, nothing
else.
> Hmmm, btw CodingStyle wants that you place bracers in else section too.
> Like this:
>
> > - } else
> > + } else {
> > - dbg("%s: error %d", __func__, status);
> > + err("%s: error %d", __func__, status);
> > + }
I totally agree with the coding style in this case, but this was a patch
to support suspend/resume, not to change style.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
