This patch is for USB driver, the subject should like:
usb: chipidea: imx: xxx
It seems your cc list format is wrong, I can only send you only even
choosing "reply all".
Reply-To:
In-Reply-To: <1474023213-15790-1-git-send-email-fabien.lahoudere@xxxxxxxxxxxxxxx>
On Fri, Sep 16, 2016 at 12:53:33PM +0200, Fabien Lahoudere wrote:
> This binding allow to disable the internal 60Mhz clock for USB host2 and
> host3.
>
> Signed-off-by: Fabien Lahoudere <fabien.lahoudere@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++
> drivers/usb/chipidea/ci_hdrc_imx.h | 1 +
> drivers/usb/chipidea/usbmisc_imx.c | 17 +++++++++++++++++
Please add binding-doc, and cc devicetree@xxxxxxxxxxxxxxx and dt
maintainer
Besides, this one should be based on the another patch [1], try to
post a patch set includes both two.
> 3 files changed, 20 insertions(+)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 96c0e33..89a9d98 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -147,6 +147,8 @@ static struct imx_usbmisc_data *usbmisc_get_init_data(struct device *dev)
> if (of_find_property(np, "external-vbus-divider", NULL))
> data->evdo = 1;
>
> + if (of_find_property(np, "disable-int60ck", NULL))
> + data->disable_int60ck = 1;
>
> if (of_usb_get_phy_mode(np) == USBPHY_INTERFACE_MODE_ULPI)
> data->ulpi = 1;
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.h b/drivers/usb/chipidea/ci_hdrc_imx.h
> index d666c9f..43bafae 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.h
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.h
> @@ -20,6 +20,7 @@ struct imx_usbmisc_data {
> unsigned int oc_polarity:1; /* over current polarity if oc enabled */
> unsigned int evdo:1; /* set external vbus divider option */
> unsigned int ulpi:1; /* connected to an ULPI phy */
> + unsigned int disable_int60ck:1; /* disable 60 MHZ clock */
> };
>
> int imx_usbmisc_init(struct imx_usbmisc_data *);
> diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
> index 5472900..bffc667 100644
> --- a/drivers/usb/chipidea/usbmisc_imx.c
> +++ b/drivers/usb/chipidea/usbmisc_imx.c
> @@ -53,6 +53,9 @@
> #define MX53_USB_CTRL_1_H3_XCVR_CLK_SEL_ULPI BIT(6)
> #define MX53_USB_UH2_CTRL_OFFSET 0x14
> #define MX53_USB_UH3_CTRL_OFFSET 0x18
> +#define MX53_USB_CLKONOFF_CTRL_OFFSET 0x24
> +#define MX53_USB_CLKONOFF_CTRL_H2_INT60CKOFF BIT(21)
> +#define MX53_USB_CLKONOFF_CTRL_H3_INT60CKOFF BIT(22)
> #define MX53_BM_OVER_CUR_DIS_H1 BIT(5)
> #define MX53_BM_OVER_CUR_DIS_OTG BIT(8)
> #define MX53_BM_OVER_CUR_DIS_UHx BIT(30)
> @@ -242,6 +245,13 @@ static int usbmisc_imx53_init(struct imx_usbmisc_data *data)
> | MX53_USB_UHx_CTRL_ULPI_INT_EN;
> writel(val, reg);
> }
> + if (data->disable_int60ck) {
> + reg = usbmisc->base +
> + MX53_USB_CLKONOFF_CTRL_OFFSET;
> + val = readl(reg)
> + | MX53_USB_CLKONOFF_CTRL_H2_INT60CKOFF;
> + writel(val, reg);
> + }
> if (data->disable_oc) {
> reg = usbmisc->base + MX53_USB_UH2_CTRL_OFFSET;
> val = readl(reg) | MX53_BM_OVER_CUR_DIS_UHx;
> @@ -264,6 +274,13 @@ static int usbmisc_imx53_init(struct imx_usbmisc_data *data)
> | MX53_USB_UHx_CTRL_ULPI_INT_EN;
> writel(val, reg);
> }
> + if (data->disable_int60ck) {
> + reg = usbmisc->base +
> + MX53_USB_CLKONOFF_CTRL_OFFSET;
> + val = readl(reg)
> + | MX53_USB_CLKONOFF_CTRL_H3_INT60CKOFF;
> + writel(val, reg);
> + }
> if (data->disable_oc) {
> reg = usbmisc->base + MX53_USB_UH3_CTRL_OFFSET;
> val = readl(reg) | MX53_BM_OVER_CUR_DIS_UHx;
> --
> 2.1.4
[1] http://www.spinics.net/lists/linux-usb/msg146832.html
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
