Hi Dan, > Option (and others) have objected to defaulting the Zero-CD behavior to > off, since it currently defaults to on and is apparently used by a few > Option customers. Keep existing Zero-CD behavior; distros can customize > the default behavior at their discretion. > > Signed-off-by: Dan Williams <dcbw@xxxxxxxxxx> > > --- > Please apply for 2.6.29; thanks! > > diff --git a/drivers/usb/storage/option_ms.c b/drivers/usb/storage/option_ms.c > index 353f922..090e0ea 100644 > --- a/drivers/usb/storage/option_ms.c > +++ b/drivers/usb/storage/option_ms.c > @@ -30,7 +30,7 @@ > #define ZCD_FORCE_MODEM 0x01 > #define ZCD_ALLOW_MS 0x02 > > -static unsigned int option_zero_cd = ZCD_FORCE_MODEM; > +static unsigned int option_zero_cd = ZCD_ALLOW_MS; > module_param(option_zero_cd, uint, S_IRUGO | S_IWUSR); > MODULE_PARM_DESC(option_zero_cd, "ZeroCD mode (1=Force Modem (default)," > " 2=Allow CD-Rom"); the comment is than no longer matching the default setting. You would have to fix that one, too. However I am objecting against this patch. The few Option customers that want the storage to be default can use this option. Why bother the distro and everybody else with it? Can we please get a list of people and companies who wants to use the storage option of these devices. I simply don't see their use cases for it and why this has to be the default. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
