Moving the CONFIG_USB_ULPI_BUS option to the top-level Kconfig file means that we can enable it without any of the other USB support, leading to a build error because Kbuild never enters the drivers/usb/common/ directory without CONFIG_USB_COMMON: ERROR: "ulpi_unregister_driver" [drivers/phy/phy-tusb1210.ko] undefined! ERROR: "__ulpi_register_driver" [drivers/phy/phy-tusb1210.ko] undefined! ERROR: "ulpi_write" [drivers/phy/phy-tusb1210.ko] undefined! This adds a 'select USB_COMMON' for the symbol, similar to what we have for related options. Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Fixes: ad764c49f65a ("usb: Kconfig: move ulpi bus support out of host") --- drivers/usb/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index 6dfa10af7185..989c6208678f 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -162,6 +162,7 @@ config USB_LED_TRIG config USB_ULPI_BUS tristate "USB ULPI PHY interface support" + select USB_COMMON help UTMI+ Low Pin Interface (ULPI) is specification for a commonly used USB 2.0 PHY interface. The ULPI specification defines a standard set -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html