Re: [PATCH 2/3] cdc-acm: cleanup debugging in submission path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2016-09-09 at 14:15 +0200, Greg KH wrote:
> On Wed, Sep 07, 2016 at 02:30:02PM +0200, Oliver Neukum wrote:
> > Actually make it retutn useful information.
> > 
> > Signed-off-by: Oliver Neukum <oneukum@xxxxxxxx>
> > ---
> >  drivers/usb/class/cdc-acm.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> > index ea7d361..7c21567 100644
> > --- a/drivers/usb/class/cdc-acm.c
> > +++ b/drivers/usb/class/cdc-acm.c
> > @@ -366,17 +366,17 @@ static int acm_submit_read_urb(struct acm *acm, int index, gfp_t mem_flags)
> >  	if (!test_and_clear_bit(index, &acm->read_urbs_free))
> >  		return 0;
> >  
> > -	dev_vdbg(&acm->data->dev, "%s - urb %d\n", __func__, index);
> > -
> >  	res = usb_submit_urb(acm->read_urbs[index], mem_flags);
> >  	if (res) {
> >  		if (res != -EPERM) {
> >  			dev_err(&acm->data->dev,
> > -					"%s - usb_submit_urb failed: %d\n",
> > -					__func__, res);
> > +					"urb %d failed submission with %\n",
> > +					index, res);
> 
> Did you build this code?
> 
> :(
> 

Sorry, but yes I did compile it. It produces a warning, but it compiles.
I'll resubmit.

	Sorry
		Oliver




--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux