(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Wed, 28 Jan 2009 02:34:10 -0800 (PST) bugme-daemon@xxxxxxxxxxxxxxxxxxx wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=12559 > > Summary: Huawei E169 doesn't work as mass storage anymore > Product: Drivers > Version: 2.5 > KernelVersion: 2.6.28.2 > Platform: All > OS/Version: Linux > Tree: Mainline > Status: NEW > Severity: normal > Priority: P1 > Component: USB > AssignedTo: greg@xxxxxxxxx > ReportedBy: kpalberg@xxxxxxxxx > > > Latest tested working kernel version: 2.6.27.7 > Earliest tested failing kernel version: 2.6.28.2 A regression. > Distribution: Debian Etch > Hardware Environment: x86 > Software Environment: > > Problem Description: > Huawei E169 HSDPA USB modem (ID 12d1:1001) also functions as a USB memory > stick. It has a microsd memory card slot for this. This USB storage is no > longer recognized. It also has a CD-ROM mass storage device for the windows > drivers and this is not recognized either (doesn't matter). > > Both storages used to work. The following diff is what caused the regression > and reversing it makes 2.6.28.2 work correctly: > > --- linux-2.6.27.7/drivers/usb/storage/initializers.c 2008-11-21 > 01:02:37.000000000 +0200 > +++ linux-2.6.28.2/drivers/usb/storage/initializers.c 2009-01-25 > 02:42:07.000000000 +0200 > @@ -95,11 +95,10 @@ > { > int result; > > - us->iobuf[0] = 0x1; > result = usb_stor_control_msg(us, us->send_ctrl_pipe, > USB_REQ_SET_FEATURE, > USB_TYPE_STANDARD | USB_RECIP_DEVICE, > - 0x01, 0x0, us->iobuf, 0x1, 1000); > + 0x01, 0x0, NULL, 0x0, 1000); > US_DEBUGP("usb_control_msg performing result is %d\n", result); > return (result ? 0 : -1); > } > > > Steps to reproduce: > Attach the stick. > Apparenty caused by commit 1460e5e44cc5ecad7704f63b10dcb3a59d0e008b Author: fangxiaozhi <huananhu@xxxxxxxxxx> AuthorDate: Wed Oct 15 14:15:36 2008 +0800 Commit: Greg Kroah-Hartman <gregkh@xxxxxxx> CommitDate: Wed Oct 22 10:05:28 2008 -0700 USB: support Huawei data card product IDs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
