Hi,
I have an imx53 based boards with an ULPI phy (smsc 3315) connected to
usbh2 and usbh3 and encounter problem with patch
"usb: chipidea: coordinate usb phy initialization for different phy type".
In drivers/usb/chipidea/core.c:ci_usb_phy_init, if I call
hw_phymode_configure() before usb_phy_init(), the system freeze. If I
call usb_phy_init() before hw_phymode_configure(), everything works fine.
So I wonder if someone test ULPI phy? and if the following piece of
patch (that works in my case) could be acceptable :
#######################################################################
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 69426e6..21218f8 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -383,6 +383,7 @@ static int ci_usb_phy_init(struct ci_hdrc *ci)
case USBPHY_INTERFACE_MODE_UTMI:
case USBPHY_INTERFACE_MODE_UTMIW:
case USBPHY_INTERFACE_MODE_HSIC:
+ case USBPHY_INTERFACE_MODE_ULPI:
ret = _ci_usb_phy_init(ci);
if (!ret)
hw_wait_phy_stable();
@@ -390,7 +391,6 @@ static int ci_usb_phy_init(struct ci_hdrc *ci)
return ret;
hw_phymode_configure(ci);
break;
- case USBPHY_INTERFACE_MODE_ULPI:
case USBPHY_INTERFACE_MODE_SERIAL:
hw_phymode_configure(ci);
ret = _ci_usb_phy_init(ci);
#######################################################################
If not, the patch says that actual solution this is not the best
solution so what could be the better solution?
Thanks
Fabien
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
