Re: [PATCH 1/3] usb: gadgetfs: introduce feature control mechanism

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 7 Sep 2016, Felipe Balbi wrote:

> > --- a/include/uapi/linux/usb/gadgetfs.h
> > +++ b/include/uapi/linux/usb/gadgetfs.h
> > @@ -85,4 +85,33 @@ struct usb_gadgetfs_event {
> >   */
> >  #define    GADGETFS_CLEAR_HALT    _IO('g', 3)
> >  
> > +
> > +
> > +struct usb_gadgetfs_features {
> > +     uint64_t bitmap[4];
> 
> this should really be:
> 
> 	uint64_t features0;
> 
>         /* Keep 24 bytes reserved for possible future usage */
>         uint8_t RESERVED[24];

Isn't this really extreme overkill?  I would be surprised if gadgetfs 
ever supports more than 10 features.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux