Hans Petter Selasky <hps@xxxxxxxxxxx> writes:
> On 09/06/16 08:44, Felipe Balbi wrote:
>> Hi,
>>
>> Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> writes:
>>> > According to USB 3.1 Specification, that field is 2
>>> > bytes wide and is named with a 'w' prefix, not 'b'.
>>> >
>>> > Just to make grepping in the spec easier, let's
>>> > match the name.
>>> >
>>> > Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>
>> I'll wait for another week or so, if nobody has any objections to this
>> series, I plan on sending it to Greg on my pull request.
>
> FYI: Affects Linux's libusb header files too. They have the same
> mis-spelling.
Oh darn it. I'm touching <uapi/linux/usb/ch9.h>. I'm not sure we can go
ahead with this. At least not that easily. I wonder if below would work:
diff --git a/include/uapi/linux/usb/ch9.h b/include/uapi/linux/usb/ch9.h
index a8acc24765fe..87ad22e81a8b 100644
--- a/include/uapi/linux/usb/ch9.h
+++ b/include/uapi/linux/usb/ch9.h
@@ -889,7 +889,8 @@ struct usb_ss_cap_descriptor { /* Link Power Management */
#define USB_5GBPS_OPERATION (1 << 3) /* Operation at 5Gbps */
__u8 bFunctionalitySupport;
__u8 bU1devExitLat;
- __le16 bU2DevExitLat;
+#define bU2DevExitLat wU2DevExitLat
+ __le16 wU2DevExitLat;
} __attribute__((packed));
#define USB_DT_USB_SS_CAP_SIZE 10
Then we shouldn't break anything. A quick build test shows that it
builds just fine.
--
balbi
Attachment:
signature.asc
Description: PGP signature
