Re: [PATCH 2/8] musb_host: fix endpoint allocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Gupta, Ajay Kumar wrote:

-----Original Message-----
From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-owner@xxxxxxxxxxxxxxx] On Behalf Of Sergei
Shtylyov
Sent: Wednesday, January 28, 2009 2:59 AM
To: felipe.balbi@xxxxxxxxx; gregkh@xxxxxxx
Cc: linux-usb@xxxxxxxxxxxxxxx; davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx; david-b@xxxxxxxxxxx
Subject: [PATCH 2/8] musb_host: fix endpoint allocation

The driver prevents using the same numbered Rx/Tx endpoints simultaneously for
the periodic transfers -- which would actually be correct unless they share the
same FIFO. Use 'in_qh' and 'out_qh' fields of the 'struct musb_hw_ep' to check
the endpoint's business and get rid of now completely useless 'periodic' array
in the 'struct musb'.  While at it, optimize the loop induction variable in the
endpoint lookup code and remove duplicate/unneeded code elsewhere...

Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

---
This is hopefully a better replacement for the patch originally posted by Ajay
Kumar Gupta (http://marc.info/?l=linux-usb&m=122337221417651).
The patch is against the recent Linus' kernel...

Why didn't you remove periodic[32] field from "struct musb"?
	struct musb_qh		*periodic[32];	/* tree of interrupt+iso */

Oops, probably a reject was missed (though I seem to remember fixing it)... will repost.

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux