Re: usb: chipidea: hdc: kernel panic during shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 25.08.2016 um 08:44 schrieb Peter Chen:
> On Thu, Aug 25, 2016 at 07:06:12AM +0200, Stefan Wahren wrote:
>> Hi Alan,
>>
>> i tried the following patch:
>> --- a/drivers/usb/chipidea/host.c
>> +++ b/drivers/usb/chipidea/host.c
>> @@ -185,6 +185,8 @@ static void host_stop(struct ci_hdrc *ci)
>>  
>>         if (hcd) {
>>                 usb_remove_hcd(hcd);
>> +               ci_role_stop(ci);
>> +               synchronize_irq(ci->irq);
> Would you please just add below line to see if this problem can be
> fixed?
> +	ci->role = CI_ROLE_END;
>
> When ci->role is CI_ROLE_END, neither host nor device interrupt handler
> will run.

I would add this before synchronize_irq() as Alan suggested.

>
> What is your controller role? (dr_mode = host, peripheral or otg)?

I'm using the unmodified arch/arm/boot/dts/imx23-olinuxino.dts so:

dr_mode = host

> Besides, you would please add below line at core.c to show what
> interrupt occurs at that time:
>
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index b5c155b..e6b8a7e 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -596,6 +596,12 @@ static irqreturn_t ci_irq(int irq, void *data)
>  	/* Handle device/host interrupt */
>  	if (ci->role != CI_ROLE_END)
>  		ret = ci_role(ci)->irq(ci);
> +	else
> +		dev_info(ci->dev, "otgsc:0x%x, usbsts:0x%x\n",
> +				hw_read_otgsc(ci, ~0),
> +				hw_read_intr_status(ci) & hw_read_intr_enable(ci)
> +		);
> +
>  
>  	return ret;
>  }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux