On 24 August 2016 at 20:48, Bjørn Mork <bjorn@xxxxxxx> wrote: > Rafał Miłecki <zajec5@xxxxxxxxx> writes: > >> The last big missing thing is Documentation update (this is why I'm >> sending RFC). Greg pointed out we should have some entries in >> Documentation/ABI, but it seems none of triggers have it. > > There's a lot missing, but there is at least one exception: > The "inverted" attribute of the gpio and backlight triggers is > documented as part of Documentation/ABI/testing/sysfs-class-led > >> Any idea why is that? > > Manual enforcement fails from time to time? The requirement was less > strict in the early days of sysfs? Does it matter? > >> Do we need to change it? Or is it required for new code only? > > The lack of ABI docs is a bug. Don't add new code with known bugs. Old > code should be fixed, but there is no immediate *need* to fix it. Don't get me wrong. I care about code quality and documentation. I mean to follow kernel rules. It's just some things may be not clear to ppl and it would be nice to get any explanation/help. That said thanks a lot of your e-mail, I'll try to expand pointed Documentation. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
