On Wed, Jul 27, 2016 at 02:46:32PM +0200, Mathieu OTHACEHE wrote: > > > in that case, where is the initialisation to 0 you avoid and hence > > can remove from the code? > > Hi, > > In v1, kzalloc was useful to avoid wFlags initialisation to 0 : > > https://lkml.org/lkml/2016/5/12/139 > > In v2 wFlags initialisation has be removed so this patch has no purpose > anymore, my bad. Actually, the kzalloc is now making sure that the cXon and cXoff fields are always initialised. So I think the change is good, but please update commit message. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html