On 08/17/2016 04:18 PM, Oliver Neukum wrote: > On Wed, 2016-08-17 at 14:26 +0300, Binyamin Sharet wrote: >> On 08/16/2016 06:02 PM, Alan Stern wrote: >>> On Tue, 16 Aug 2016, Binyamin Sharet wrote: >>> >>>> Kernel version: raspberrypi 4.4.6-v7+ #871 >>>> Driver source file: drivers/net/usb/kaweth.c >>>> Umap2 command line: umap2vsscan -P <PHY> -s 0557:2002 >>>> >>>> After connecting such a device, NULL pointer dereference in the kernel >>>> and USB stops responding. >>>> >>>> This issue was reproduced with other VID/PIDs that use this driver. >>>> >>>> Binyamin Sharet >>>> Cisco, STARE-C >>>> >>>> << Attached: 0557_2002_dmesg.log >> >>> This looks like a bug in the kaweth driver. kaweth_probe() assigns >>> >>> kaweth->intf = intf; >>> >>> but it needs to happen much earlier in the routine, probably along with >>> the initializations of kaweth->dev and kaweth->net. >>> >>> Alan Stern >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >>> the body of a message to majordomo@xxxxxxxxxxxxxxx >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> kernel: 4.8-rc2 >> result: not reproduced >> >> > This is getting odd. There have been no substantial changes to kaweth > between v4.4 and v4.8-rc2. I still think Alan's analysis is valid. > Are you sure of your test setup? Same kernel configuration? > > Regards > Oliver > > No. I am not. The issue was found on raspbian with kernel 4.4.6, and was not found on ubuntu 16.04 with mainline kernel 4.8-rc2, I don't have much experience with compiling kernels, so it will take me some time to build mainline kernel for the raspberry pi. My indication that the driver was loaded is a few lines in the dmesg from kaweth: Downloading firmware... Firmware loaded. I'll be back... probe of 1-1.1:1.0 failed with error -5 after that there's USB disconnection, and the machine keeps working as before. If you have any suggestion on how to perform it better, I'd be very glad to hear. -- Binyamin Sharet, Cisco, STARE-C -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
