Re: [Umap2][9/11][05c5:0002] NULL pointer dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 16 Aug 2016, Binyamin Sharet wrote:

> Kernel version: raspberrypi 4.4.6-v7+ #871
> Driver source file: drivers/usb/serial/digi_acceleport.c
> Umap2 command line: umap2vsscan -P <PHY> -s 05c5:0002
> 
> After connecting such a device, NULL pointer dereference in the kernel.
> 
> Binyamin Sharet
> Cisco, STARE-C
> 
> << Attached:  05c5_0002_dmesg.log >>

This looks like a bug in the digi_acceleport driver.  digi_startup() 
does this:

	serial_priv->ds_oob_port_num = serial->type->num_ports;
	serial_priv->ds_oob_port = serial->port[serial_priv->ds_oob_port_num];

Even without knowing exactly what this is supposed to be doing, one
gets the definite impression that the first line should be:

	serial_priv->ds_oob_port_num = serial->type->num_ports - 1;

Johan?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux