Re: [PATCH 2/2] usb: Kconfig: move ulpi bus to common

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 15, 2016 at 04:07:14PM +0300, Heikki Krogerus wrote:
> Hi,
> 
> On Fri, Jul 08, 2016 at 04:15:23PM +0800, Peter Chen wrote:
> > The ULPI bus is not only for host, but for device mode too, so move
> > it out from host's Kconfig.
> > 
> > Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > Signed-off-by: Peter Chen <peter.chen@xxxxxxx>
> > ---
> >  drivers/usb/common/Kconfig | 21 +++++++++++++++++++++
> >  drivers/usb/core/Kconfig   | 21 ---------------------
> >  2 files changed, 21 insertions(+), 21 deletions(-)
> > 
> > diff --git a/drivers/usb/common/Kconfig b/drivers/usb/common/Kconfig
> > index 951b1d0..e251aec 100644
> > --- a/drivers/usb/common/Kconfig
> > +++ b/drivers/usb/common/Kconfig
> > @@ -7,3 +7,24 @@ config USB_LED_TRIG
> >  	  Say Y here if you are working on a system with led-class supported
> >  	  LEDs and you want to use them as activity indicators for USB host or
> >  	  gadget.
> > +
> > +config USB_ULPI_BUS
> > +	tristate "USB ULPI PHY interface support"
> > +	depends on USB_SUPPORT
> > +	help
> > +	  UTMI+ Low Pin Interface (ULPI) is specification for a commonly used
> > +	  USB 2.0 PHY interface. The ULPI specification defines a standard set
> > +	  of registers that can be used to detect the vendor and product which
> > +	  allows ULPI to be handled as a bus. This module is the driver for that
> > +	  bus.
> > +
> > +	  The ULPI interfaces (the buses) are registered by the drivers for USB
> > +	  controllers which support ULPI register access and have ULPI PHY
> > +	  attached to them. The ULPI PHY drivers themselves are normal PHY
> > +	  drivers.
> > +
> > +	  ULPI PHYs provide often functions such as ADP sensing/probing (OTG
> > +	  protocol) and USB charger detection.
> > +
> > +	  To compile this driver as a module, choose M here: the module will
> > +	  be called ulpi.
> > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> > index dd28010..d6e43ce 100644
> > --- a/drivers/usb/core/Kconfig
> > +++ b/drivers/usb/core/Kconfig
> > @@ -82,24 +82,3 @@ config USB_OTG_FSM
> >  	help
> >  	  Implements OTG Finite State Machine as specified in On-The-Go
> >  	  and Embedded Host Supplement to the USB Revision 2.0 Specification.
> > -
> > -config USB_ULPI_BUS
> > -	tristate "USB ULPI PHY interface support"
> > -	depends on USB_SUPPORT
> 
> This patch does not apply. The above line has been removed at one
> point.
> 
> Once you resend, please re-add the dependency once you move the config
> to drivers/usb/common/Kconfig.
> 

I don't need to add "USB_SUPPORT" since all USB Kconfig is under
USB_SUPPORT, you can check drivers/usb/Kconfig.

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux