Re: [PATCH] watchdog: pcwd_usb: don't print error when allocating urb fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 11, 2016 at 11:23:40PM +0200, Wolfram Sang wrote:
> kmalloc will print enough information in case of failure.
> 
> Signed-off-by: Wolfram Sang <wsa-dev@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/pcwd_usb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/pcwd_usb.c b/drivers/watchdog/pcwd_usb.c
> index 68952d9ccf8394..99ebf6ea3de648 100644
> --- a/drivers/watchdog/pcwd_usb.c
> +++ b/drivers/watchdog/pcwd_usb.c
> @@ -666,10 +666,8 @@ static int usb_pcwd_probe(struct usb_interface *interface,
>  
>  	/* allocate the urb's */
>  	usb_pcwd->intr_urb = usb_alloc_urb(0, GFP_KERNEL);
> -	if (!usb_pcwd->intr_urb) {
> -		pr_err("Out of memory\n");
> +	if (!usb_pcwd->intr_urb)
>  		goto error;
> -	}
>  
>  	/* initialise the intr urb's */
>  	usb_fill_int_urb(usb_pcwd->intr_urb, udev, pipe,
> -- 
> 2.8.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux