Hi Robert, [auto build test WARNING on usb/usb-testing] [also build test WARNING on v4.8-rc1 next-20160809] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/robert-foss-collabora-com/usb-xhci-plat-Enable-PM-async-resume-suspend/20160809-234302 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: i386-randconfig-s0-201632 (attached as .config) compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers/usb/host/xhci-plat.c: In function 'xhci_plat_suspend': >> drivers/usb/host/xhci-plat.c:303:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (ret < 0) ^~ drivers/usb/host/xhci-plat.c:305:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' return ret; ^~~~~~ drivers/usb/host/xhci-plat.c: In function 'xhci_plat_resume': drivers/usb/host/xhci-plat.c:327:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (ret < 0) ^~ drivers/usb/host/xhci-plat.c:329:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' return ret; ^~~~~~ vim +/if +303 drivers/usb/host/xhci-plat.c 287 288 if (!IS_ERR(clk)) 289 clk_disable_unprepare(clk); 290 usb_put_hcd(hcd); 291 292 return 0; 293 } 294 295 #ifdef CONFIG_PM_SLEEP 296 static int xhci_plat_suspend(struct device *dev) 297 { 298 struct usb_hcd *hcd = dev_get_drvdata(dev); 299 struct xhci_hcd *xhci = hcd_to_xhci(hcd); 300 int ret; 301 302 ret = pm_runtime_get_sync(dev); > 303 if (ret < 0) 304 atomic_dec(&dev->power.usage_count); 305 return ret; 306 /* 307 * xhci_suspend() needs `do_wakeup` to know whether host is allowed 308 * to do wakeup during suspend. Since xhci_plat_suspend is currently 309 * only designed for system suspend, device_may_wakeup() is enough 310 * to dertermine whether host is allowed to do wakeup. Need to 311 * reconsider this when xhci_plat_suspend enlarges its scope, e.g., --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: Binary data
