On 05-08-16, 11:49, Alan Stern wrote:
> The early-exit pathway in hub_activate, added by commit e50293ef9775
> ("USB: fix invalid memory access in hub_activate()") needs
> improvement. It duplicates code that is already present at the end of
> the subroutine, and it neglects to undo the effect of a
> usb_autopm_get_interface_no_resume() call.
>
> This patch fixes both problems by making the early-exit pathway jump
> directly to the end of the subroutine. It simplifies the code at the
> end by merging two conditionals that actually test the same condition
> although they appear different: If type < HUB_INIT3 then type must be
> either HUB_INIT2 or HUB_INIT, and it can't be HUB_INIT because in that
> case the subroutine would have exited earlier.
>
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> CC: <stable@xxxxxxxxxxxxxxx> #4.4+
>
> ---
>
>
> [as1807]
>
>
> drivers/usb/core/hub.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
