On Tue, 2016-08-02 at 13:32 -0700, Guenter Roeck wrote:
> +static int tcpm_set_polarity(struct tcpm_port *port,
> + enum typec_cc_polarity polarity)
> +{
> + tcpm_log(port, "polarity %d", polarity);
> +
> + port->polarity = polarity;
> +
> + return port->tcpc->set_polarity(port->tcpc, port->polarity);
> +}
Here you don't care about the result.
> +
> +static int tcpm_set_vconn(struct tcpm_port *port, bool enable)
> +{
> + int ret = 0;
> +
> + tcpm_log(port, "vconn:=%d", enable);
> +
> + ret = port->tcpc->set_vconn(port->tcpc, enable);
> + if (!ret) {
> + port->con.vconn_role = enable ? TYPEC_SOURCE
> + : TYPEC_SINK;
> + typec_set_vconn_role(port->typec_port,
> port->con.vconn_role);
> + }
> +
> + return ret;
> +}
But here you do. Which is right?
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
