I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> --- drivers/usb/gadget/legacy/inode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index aa3707b..4cedfa3 100644 --- a/drivers/usb/gadget/legacy/inode.c +++ b/drivers/usb/gadget/legacy/inode.c @@ -1895,9 +1895,9 @@ static unsigned default_uid; static unsigned default_gid; static unsigned default_perm = S_IRUSR | S_IWUSR; -module_param (default_uid, uint, 0644); -module_param (default_gid, uint, 0644); -module_param (default_perm, uint, 0644); +module_param (default_uid, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param (default_gid, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param (default_perm, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static struct inode * -- 2.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
